<html>
<head><meta charset="utf-8"><title>Merge permissions for RFC repo · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html">Merge permissions for RFC repo</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="210499282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210499282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210499282">(Sep 18 2020 at 10:05)</a>:</h4>
<p>It seems that I've once again lost merge permissions on rust-lang/rfcs. cc <span class="user-mention" data-user-id="116122">@simulacrum</span> since this happened before when I tried to merge the inline asm RFC.</p>



<a name="210511155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210511155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210511155">(Sep 18 2020 at 12:26)</a>:</h4>
<p><span class="user-mention" data-user-id="143274">@Amanieu</span> hm, you should have permissions.</p>



<a name="210511167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210511167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210511167">(Sep 18 2020 at 12:27)</a>:</h4>
<p>can you tell me what the error is/what you're seeing?</p>



<a name="210529054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210529054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210529054">(Sep 18 2020 at 14:47)</a>:</h4>
<p>Oh nevermind it seems that it just needed to be approved.</p>



<a name="210529125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210529125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210529125">(Sep 18 2020 at 14:47)</a>:</h4>
<p>ah okay, sg</p>



<a name="210533687"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210533687" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210533687">(Sep 18 2020 at 15:16)</a>:</h4>
<p>Bleh I messed up the merge. Can someone quickly approve <a href="https://github.com/rust-lang/rfcs/pull/2986">https://github.com/rust-lang/rfcs/pull/2986</a>?</p>



<a name="210533916"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210533916" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210533916">(Sep 18 2020 at 15:16)</a>:</h4>
<p>just merged</p>



<a name="210534118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210534118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210534118">(Sep 18 2020 at 15:18)</a>:</h4>
<p>Since I don't have permissions to push directly to the master branch I had to push the fixup commit directly to the PR branch. I got mixed up with my remotes and accidentally deleted everything.</p>



<a name="210534149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210534149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210534149">(Sep 18 2020 at 15:18)</a>:</h4>
<p>no worries</p>



<a name="210534200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210534200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210534200">(Sep 18 2020 at 15:18)</a>:</h4>
<p>We can probably just drop the branch protection stuff, it's really only there as a safeguard</p>



<a name="210534582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210534582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210534582">(Sep 18 2020 at 15:21)</a>:</h4>
<p>Everyone who usually merges PRs ignores the branch protection and push directly to master anyways. In fact pushing to master is explicitly in the RFC merge procedure on the forge.</p>



<a name="210534628"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210534628" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210534628">(Sep 18 2020 at 15:21)</a>:</h4>
<p>I think libs team does have rights to push</p>



<a name="210539289"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210539289" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210539289">(Sep 18 2020 at 15:54)</a>:</h4>
<p>No, I don't have permissions to bypass the branch protection. All changes to master have to go through a PR.</p>



<a name="210539320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210539320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210539320">(Sep 18 2020 at 15:54)</a>:</h4>
<p>interesting</p>



<a name="210539361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Merge%20permissions%20for%20RFC%20repo/near/210539361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Merge.20permissions.20for.20RFC.20repo.html#210539361">(Sep 18 2020 at 15:54)</a>:</h4>
<p>ah "Required status checks will still prevent these people, teams and apps from merging if the checks fail. "</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>